Skip to content

Update Maven to 3.9.9, Wrapper to 3.3.2 #2425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2025
Merged

Conversation

afranken
Copy link
Member

Description

Update Maven to 3.9.9, Wrapper to 3.3.2
Ran mvn wrapper:wrapper to update all wrapper files.

Related Issue

N/A

Tasks

  • I have signed the CLA.
  • I have written tests and verified that they fail without my change.

@afranken afranken self-assigned this May 31, 2025
@afranken afranken requested a review from Copilot June 5, 2025 11:26
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Maven Wrapper by bumping the Maven distribution from 3.9.6 to 3.9.9 and the wrapper version from 3.2.0 to 3.3.2, with corresponding updates to the wrapper scripts and CHANGELOG.

  • Updated version strings in mvnw.cmd to reflect Maven Wrapper version 3.3.2.
  • Adjusted properties in .mvn/wrapper/maven-wrapper.properties to point to the new Maven distribution and to introduce new keys (wrapperVersion, distributionType).
  • Updated CHANGELOG.md to document these version bumps.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
mvnw.cmd Updated batch script to reflect the new wrapper version and added a mixed PowerShell block for enhanced processing.
CHANGELOG.md Updated the changelog to list the bumped dependency versions.
.mvn/wrapper/maven-wrapper.properties Modified properties to update Maven distribution and wrapper versions.
Comments suppressed due to low confidence (2)

mvnw.cmd:30

  • Consider adding an inline comment explaining the purpose of initializing MVNW_ARG0_NAME (and the related environment variables) to assist future maintainers.
@IF "%__MVNW_ARG0_NAME__%"=="" (SET __MVNW_ARG0_NAME__=%~nx0)

mvnw.cmd:35

  • Consider adding inline comments to clarify the interaction between the batch section and the embedded PowerShell block, outlining the conversion process for improved readability.
@FOR /F "usebackq tokens=1* delims==" %%A IN (`powershell -noprofile "& {$scriptDir='%~dp0'; $script='%__MVNW_ARG0_NAME__%'; icm -ScriptBlock ([Scriptblock]::Create((Get-Content -Raw '%~f0'))) -NoNewScope}"`) DO @(

@afranken afranken merged commit 6f28779 into main Jun 8, 2025
6 checks passed
@afranken afranken deleted the update-maven-to-latest-v3 branch June 8, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant