feat: support file URL in Ignitor #2797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL is converted to an absolute path, so the rest works as before. This is to enable applications written in ESM to do `new Ignitor(import.meta.url)` as the `__dirname` variable doesn't exist in ESM.
|
How about moving this to a helper function inside |
|
I don't know yet if it will be used elsewhere. How about we move it to a helper function the next time I need it? |
|
Yup. Sounds like a deal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL is converted to an absolute path, so the rest works as before.
This is to enable applications written in ESM to do
new Ignitor(import.meta.url)as the
__dirnamevariable doesn't exist in ESM.