Skip to content

Conversation

kdkasad
Copy link
Contributor

@kdkasad kdkasad commented Dec 11, 2020

Fixes #124 by avoiding h4 tags in figcaption elements. I've added to post-content.css so the look of captions should not change.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adityatelange
Copy link
Owner

adityatelange commented Dec 12, 2020

@kdkasad Now that we are including it in theme itself, how about customizing it and make it look like the cover image ?
Also don't forget to mention Co-authors in commit message https://github.com/gohugoio/hugo/commits/master/tpl/tplimpl/embedded/templates/shortcodes/figure.html

or nvm I'll add it like in 6c4e094

@kdkasad
Copy link
Contributor Author

kdkasad commented Dec 12, 2020

how about customizing it and make it look like the cover image ?

How exactly? The embedded images already look like the cover image.

@adityatelange adityatelange merged commit f9236d9 into adityatelange:master Dec 15, 2020
@kdkasad kdkasad deleted the custom-figcaption branch December 15, 2020 17:33
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image captions are added to the table of contents
2 participants