Improve breadcrumb schema generation #1471
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
akkuman
added a commit
to akkuman/akkuman.github.io
that referenced
this pull request
Oct 12, 2024
参见 adityatelange/hugo-PaperMod#1471 等pr合并后删除该文件
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
When run with
HUGO_UGLYURLS=true, the position count is wrong and a comma is missing between array elements, causing errors during minification.This PR decouples position counting from (potentially skipped) bc_list array indices and length, making it slightly more robust.
Was the change discussed in an issue or in the Discussions before?
Also fixes #1441 and its reproducer, which shows the same behavior
PR Checklist