Skip to content

Conversation

sebinbabu
Copy link
Contributor

What does this PR change? What problem does it solve?

This PR fixes the hugo build fails due to not having an expected comma in the schema_json template.

Was the change discussed in an issue or in the Discussions before?

Fixes #1458

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adityatelange adityatelange merged commit 3b0a811 into adityatelange:master Mar 16, 2024
@sebinbabu sebinbabu deleted the bugfix-json-layout branch March 16, 2024 16:11
@pierreprinetti
Copy link

@sebinbabu I'll just drop this here in case your templating skills overflow this very PR: #1441 ...

@adityatelange
Copy link
Owner

@sebinbabu I'll just drop this here in case your templating skills overflow this very PR: #1441 ...

Unrelated.

@pierreprinetti
Copy link

pierreprinetti commented Mar 20, 2024

@sebinbabu I'll just drop this here in case your templating skills overflow this very PR: #1441 ...

Unrelated.

Indeed, I can confirm it's unrelated! I'm only piggibacking because it's a comma problem in a template, in the same repository :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]In the f5c737f version, using the hugo --minify command will report an error.
3 participants