refactor(expr): simplify filter(), also cache undue case

adhocore · adhocore · commit aab941e1a3be · 2018-08-16T07:37:24.000+07:00
diff --git a/src/Expression.php b/src/Expression.php
@@ -150,16 +150,12 @@ public function filter(array $jobs, $time = null)
         foreach ($jobs as $name => $expr) {
             $expr = $this->normalizeExpr($expr);
 
-            if (isset($cache[$expr])) {
-                $dues[] = $name;
-
-                continue;
+            if (!isset($cache[$expr])) {
+                $cache[$expr] = $this->isCronDue($expr, $time);
             }
 
-            if ($this->isCronDue($expr, $time)) {
+            if ($cache[$expr]) {
                 $dues[] = $name;
-
-                $cache[$expr] = true;
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -150,16 +150,12 @@ public function filter(array $jobs, $time = null)`
`150`	`150`	`foreach ($jobs as $name => $expr) {`
`151`	`151`	`$expr = $this->normalizeExpr($expr);`
`152`	`152`
`153`		`- if (isset($cache[$expr])) {`
`154`		`- $dues[] = $name;`
`155`		`-`
`156`		`- continue;`
	`153`	`+ if (!isset($cache[$expr])) {`
	`154`	`+ $cache[$expr] = $this->isCronDue($expr, $time);`
`157`	`155`	`}`
`158`	`156`
`159`		`- if ($this->isCronDue($expr, $time)) {`
	`157`	`+ if ($cache[$expr]) {`
`160`	`158`	`$dues[] = $name;`
`161`		`-`
`162`		`- $cache[$expr] = true;`
`163`	`159`	`}`
`164`	`160`	`}`
`165`	`161`