patch: Adding new options to the progressbar #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dimtrovich
commented
Mar 26, 2024
- Ability to change label location: previously, the label was always placed at the bottom of the progressbar. This pull request lets dev choose where to place it
- Possibility of hiding the progress percentage: originally, I'd designed it to be used internally by the spinner (since we didn't need it in the spinner), but given that the spinner is a complex subject (see Feat add spinner to output #89) perhaps we could come back to it. Nevertheless, I think it could be useful in a classic case, which is why I've kept it.
adhocore
reviewed
Mar 27, 2024
adhocore
reviewed
Mar 27, 2024
remove unecessary comment and fix code-stle
adhocore
reviewed
Mar 27, 2024
adhocore
reviewed
Mar 27, 2024
adhocore
reviewed
Mar 27, 2024
adhocore
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.