Skip to content

Fix backlight, reset entering uf2 and correct branding info for M5Stamp S3 #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2024

Conversation

bill88t
Copy link
Contributor

@bill88t bill88t commented May 30, 2024

Checklist

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

  • Please provide specific title of the PR describing the change
  • Please provide related links (eg. Issue which will be closed by this Pull Request)

This checklist items that are not applicable to your PR can be deleted.


Description of Change

Fixes.
The stamp is used for the cardputer. Testing on that.
Under circuitpython the panel works correctly, but not under uf2, this PR fixes that.
When sending a reset, the board sometimes entered uf2 mode, this is fixed by disabling double reset.
Additionally improved the branding a bit cuz it annoys me seeing wrong info.

@bill88t bill88t marked this pull request as ready for review May 30, 2024 21:18
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, thanks

@hathach hathach merged commit f5410ef into adafruit:master May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants