Upload Espressif bootloader .zip and combined*.bin to board-specific dirs on S3 #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathach
approved these changes
Jun 30, 2025
hathach
reviewed
Jun 30, 2025
ac5fb6e to
1740fa6
Compare
1740fa6 to
aabf153
Compare
|
The sense of the conditional was backward; I force-pushed a change. |
hathach
approved these changes
Jun 30, 2025
|
Do you want to do the merge? And did you mean do a release now? Thanks. |
yeah we can merge and then make an relesae to test with |
|
OK, it worked! |
|
perfect !! :) |
|
@dhalbert there seems to have issue with uploading combined-ota.bin to s3 in release https://github.com/adafruit/tinyuf2/actions/runs/16029529896 |
|
fixed build with #456. The lasts command |
|
Thanks! I was following the previous style, but I understand now how it causes an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a release
tinyuf2*.zipandupdate-tinyuf2*.uf2to a board-specific directory. The upload path used to be, for example:s3://adafruit-circuit-python/bootloaders/esp32/tinyuf2-adafruit_feather_esp32s3-0.32.0.zipand now it is
s3://adafruit-circuit-python/bootloaders/esp32/adafruit_feather_esp32s3/tinyuf2-adafruit_feather_esp32s3-0.32.0.zipThis groups by board name, and reduces the large number of files at one level in S3.
combined.binand, if it exists, thecombined-ota.bin. The files are renamed to include the board name and version, for exampletinyuf2-adafruit_feather_esp32s3-0.32.0-combined.binSee https://adafruit-circuit-python.s3.amazonaws.com/index.html?prefix=bootloaders/esp32/ for both old and new hiearchies.
@hathach I have tried to be careful about this, but I'm not sure how to test the uploads without doing a release. Could you double-check the paths? Thanks.
I have already copied files to board-specific dirs using a script for the previous releases. When this is merged I will submit a PR update https://github.com/adafruit/web-firmware-installer-js to look in the new locations, and after that's merged I'll delete old uploads that are in the top-level directory.