Skip to content

Fix runtime error in buyback #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2023
Merged

Fix runtime error in buyback #113

merged 2 commits into from
Jun 28, 2023

Conversation

JoshdanG
Copy link
Collaborator

  1. Fix calling functions on wrong object
  • This allows bots to buy back to defend ancient
  1. Remove unused argument to GetTeamFightLocation
  • Doesn't change any behavior, but makes code clearer

JoshdanG added 2 commits June 26, 2023 19:06
@JoshdanG
Fix runtime error in buyback
381b700 
1. Fix calling functions on wrong object
- This allows bots to buy back to defend ancient
@JoshdanG
Remove unused argument to GetTeamFightLocation
333ba70 
Doesn't change any behavior, but makes code clearer
@adamqqqplay adamqqqplay self-requested a review June 28, 2023 02:24
adamqqqplay
adamqqqplay approved these changes Jun 28, 2023
View reviewed changes
Copy link
Owner

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adamqqqplay adamqqqplay merged commit 800e7cd into adamqqqplay:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamqqqplay adamqqqplay adamqqqplay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshdanG @adamqqqplay