Skip to content

Updating NWS8 and adding upgrades from Wang et. al. (2022) #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

Updating NWS8 and adding upgrades from Wang et. al. (2022) #393

wants to merge 17 commits into from

Conversation

cblakely97
Copy link
Contributor

  • Changing the value of omega used in HollandGet to match the value in adc_constants module
  • Eliminating the calculation of coriolis frequency from HollandGet and instead uses CORIF found in mesh module
  • Moving multiplication by boundary layer adjustment factor (BLADj) to occur after background wind field is applied
  • Moving conversion from one minute average to ten minute average multiplication to after background wind field is added
  • Moving initialization code formerly found in HollandGet and GetHollandStormData into NWS8INIT to make the code more readable
  • Adding the nws8Control namelist. This namelist contains the following options (D denotes default):
    • vortexModel = "Holland" (D) or "CLE15" - Incorporates work done in Wang et. al. (2022) that allows for the use an alternative vortex model
    • backgroundWindModel = "radialVelocityWeighted" (D) or "LC12"
      • Incorporates work done in Wang et. al. (2022) that allows for an alternative background wind model
    • BCalc = "limited" (D) or "exact"
      • "limited" is original ADCIRC where the Holland B parameter is calculated once for each time step and limited to 'reasonable' values
      • "exact" calculates Holland B for each individual node and does not limit the range of the value
    • thetaLatDep = .false. (D) or .true.
      • Original ADCIRC did not include the latitude dependency in calculating distance from the center of the storm. This option preserves legacy behavior while also allowing for more accurate calculation of distances
    • useInflow = .false. (D) or .true.
      • Original adcirc assumed an inflow angle of 0 degrees. This allows it to be calculated based on velocity
    • w_cool = 2.0 (D) or any value
      • Only used in CLE15 model. This is the magnitude of the radiative-subsidence rate in the free troposphere
    • CkCd_calc = .false. (D) or .true.
      • Only used in CLE15 model. CkCd is the ratio of exchange coefficients of enthalpy and momentum. If this is false then a constant value is used. If true then CkCd is calculated from the parametric relationship:
        • CkCd = 0.00055Vmax^2 - 0.0259Vmax + 0.763 (see Chavas et. al. (2015))
    • CkCd = 1.0 (D) or any value
      • if CkCd_calc = .false. then this is the value used for CkCd when calculating the CLE15 wind profile

References:

Chavas, D. R., Lin, N., & Emanuel, K. (2015). A Model for the Complete Radial Structure of the Tropical Cyclone Wind Field. Part I: Comparison with Observed Structure. Journal of the Atmospheric Science, 72(9), 3647-3662. https://doi.org/10.1175/JAS-D-15-0014.1

Wang, Shuai, Ning Lin, and Avantika Gori. “Investigation of Tropical Cyclone Wind Models With Application to Storm Tide Simulations.” Journal of Geophysical Research: Atmospheres 127, no. 17 (2022): e2021JD036359. https://doi.org/10.1029/2021JD036359.

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Bug fix with breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to existing feature to add new functionality
  • New feature (non-breaking change which adds functionality)
  • Breaking change (feature that would cause existing functionality to not work as expected)

Issue Number

How Has This Been Tested?

Relevant Publications (if applicable)

Chavas, D. R., Lin, N., & Emanuel, K. (2015). A Model for the Complete Radial Structure of the Tropical Cyclone Wind Field. Part I: Comparison with Observed Structure. Journal of the Atmospheric Science, 72(9), 3647-3662. https://doi.org/10.1175/JAS-D-15-0014.1

Chavas, D. R., & Lin, N. (2016). A Model for the Complete Radial Structure of the Tropical Cyclone Wind Field. Part II: Wind Field Variability. Journal of the Atmospheric Sciences, 73(8), 3093-3113. https://doi.org/10.1175/JAS-D-15-0185.1

Lin, N., and D. Chavas (2012), On hurricane parametric wind and applications in storm surge modeling, J. Geophys. Res., 117, D09120, doi:10.1029/2011JD017126.

Wang, Shuai, Ning Lin, and Avantika Gori. “Investigation of Tropical Cyclone Wind Models With Application to Storm Tide Simulations.” Journal of Geophysical Research: Atmospheres 127, no. 17 (2022): e2021JD036359. https://doi.org/10.1029/2021JD036359.

Wang, S., N. Lin, A. Gori. (2022) "New wind forcing option (CLE15 wind model) for hurricane surge simulation with ADCIRC." DesignSafe-CI. https://doi.org/10.17603/ds2-xd0r-bk81 v1

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • My code is up-to-date and tested with changes from the latest version of main

If any of the above are not checked, please explain why:

Further comments

This pull request incorporates the upgrades to NWS = 8 found in Wang et. al., (2022) into the main version of ADCIRC. Formerly, this capability was only found in the DesignSafe repository and required the use of cmake compiler flags to enable the CLE15 and LC12 vortex and background winds. This commit instead moves activation to a namelist that preserves legacy behavior by default.

cblakely97 and others added 12 commits February 14, 2024 11:34
@krober10nd
Copy link

When you say "background winds" do you mean synoptic scale wind fields far from the vortex or do you mean how you're adding storm motion into the vortex wind field? If the latter, that is referred to as storm motion asymmetry.

@cblakely97
Copy link
Contributor Author

I used the terminology "background winds" because that is what it is referred to in Lin and Chavas (2012). I can change that option to "asymmetryModel" or similar if that would be more descriptive.

@tgasher
Copy link
Contributor

tgasher commented May 22, 2024 via email

@WPringle
Copy link
Contributor

@cblakely97 Please check the windspeed_averaging_minute and add to the header for this PR.

@WPringle
Copy link
Contributor

See this namelist implementation in OM2D: CHLNDDEV/OceanMesh2D#317

WPringle and others added 3 commits October 23, 2024 13:12
@WPringle
add radially varying reduction factors and rotation for LC12, add bac…
54ebb05 
…kgroundWindFac that is consistent with the reduction factor for LC12 at Rmax, add non_cyclostropic_part to the Holland gradient wind fields (triggered by the BCalc namelist option, which may be better to be renamed to cyclostrophic True or False), and otherwise some cleaning up the code
@cblakely97
Update cle15-lc12 branch with latest commits from main ADCIRC branch
2c1bfa8 
   - Merge changes from main into diverging cle15-lc12 branch in preparation for pull request
@cblakely97
Add missing io error message to nws8Control namelist read
5bb2b55 
   - Adds 'ios_nml_error_msg' to subroutine calls that read nws8Control namelist in read_input.F
@cblakely97 cblakely97 closed this Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cblakely97 @krober10nd @tgasher @WPringle