Skip to content

getArtifact function using deprecated (due to security and usability issues) buffer function  #1618

@twalshOG

Description

@twalshOG

Describe the bug
Receive a deprecation warning when using downloading an artifact

To Reproduce
Steps to reproduce the behavior:

  1. Use the the downloadArtifact functionality in a Github actions pipeline
  2. Note you get the following error

(node:1671) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use node --trace-deprecation ... to show where the warning was created)

Code producing the warning

import * as artifact from '@actions/artifact';
.........
  const response = await artifact.default.getArtifact(artifactName);
  const artifactClient = artifact.default;
  await artifactClient.downloadArtifact(response.artifact.id, {
    path: downloadFolder,
  });

Expected behavior
Would not get the error.
This error is due to the fact that @actions/artifact is depending on archiver 5.3.1 which in turn depends on archiver-utils 2.1.0 which use using the depreciated buffer call.

Screenshots
Screenshot 2024-01-05 at 1 05 40 PM

**Where produced **

  • Github Actions Agent: ubuntu-latest
  • Node version: Default version installed on ubuntu-latest

Additional context
Updating to a new version (3.0.0 or above) would address this issue.
The fix/update to this was already released for archiver-utils.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions