Fix null reference exception in user agent handling #3946
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a null reference exception in the JobRunner class by adding proper null safety checks when handling user agent orchestration IDs. The changes ensure that user agents are loaded before accessing them and add defensive programming practices to prevent runtime exceptions.
Key changes:
- Added call to
LoadDefaultUserAgents()to ensure user agents are initialized - Added null checks for
UserAgentscollection andProductproperty - Applied null-conditional operator for safer collection insertion
TingluoHuang
approved these changes
Jul 17, 2025
This was referenced Jul 23, 2025
LouisHaftmann
pushed a commit
to falcondev-oss/github-actions-runner
that referenced
this pull request
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that user agents are loaded and checked for null values to prevent null reference exceptions when processing orchestration IDs.