Try add orchestrationid into user-agent using token claim. #3945
+42
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the orchestration ID tracking by extracting it from JWT token claims and adding it to user-agent headers for better correlation and logging. The implementation provides fallback mechanisms and prevents duplicate entries.
Key changes:
- Adds logic to extract orchestration ID from JWT claims with fallback to secondary claim type
- Implements duplicate prevention when adding orchestration ID to user-agent headers
- Centralizes orchestration ID extraction in HostContext for runner initialization
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Runner.Worker/JobRunner.cs | Adds duplicate check before inserting orchestration ID into user-agent headers |
| src/Runner.Listener/JobDispatcher.cs | Implements orchestration ID extraction from JWT claims with fallback logic |
| src/Runner.Common/HostContext.cs | Adds JWT import and orchestration ID extraction logic during user-agent initialization |
AllanGuigou
approved these changes
Jul 16, 2025
This was referenced Jul 23, 2025
LouisHaftmann
pushed a commit
to falcondev-oss/github-actions-runner
that referenced
this pull request
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.