-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Runner Support for executing Node24 Actions #3940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d also don't use a fallback version for linux arm 32 bit
… 24 actions and update related tests. Add tests for internal node version feature flagging.
…into salmanmkc/1-node24
TingluoHuang
approved these changes
Jul 17, 2025
This was referenced Jul 23, 2025
if [[ $? -ne 0 || -z "$path" ]] # Fallback if RunnerService.js was started with node16 | ||
then | ||
nodever="node16" | ||
path=$(lsof -a -g "$procgroup" -F n | grep $nodever/bin/node | grep externals | tail -1 | cut -c2-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we missed an fi
after this line...
LouisHaftmann
pushed a commit
to falcondev-oss/github-actions-runner
that referenced
this pull request
Aug 3, 2025
This was referenced Aug 8, 2025
This was referenced Aug 8, 2025
parkerbxyz
pushed a commit
to actions/create-github-app-token
that referenced
this pull request
Aug 8, 2025
Upgrade to node 24 as runners have node 24 support: actions/runner#3940
YorikSar
added a commit
to tweag/nixpkgs
that referenced
this pull request
Aug 11, 2025
actions/runner#3940 has added support for running node24 actions and also added a corresponding test that doesn't work on aarch64-linux.
10 tasks
nixpkgs-ci bot
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Aug 12, 2025
actions/runner#3940 has added support for running node24 actions and also added a corresponding test that doesn't work on aarch64-linux. (cherry picked from commit 5c18671)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for executing Actions with node 24. It maintains support for node 20, such that users do not need to upgrade to node 24 straight away. To use node 24, users can use an Action that has already been upgraded to node 24 or to upgrade their action to node 24 themselves. For example like the below screenshot:
Unfortunately there is no 32 bit version for Linux, so there will be a warning, and the action will instead use node 20.