Feature-flagged support for JobContext.CheckRunID
#3811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheckRunId is a double
JobContext.CheckRunIDJobContext.CheckRunID
There was a problem hiding this comment.
Pull Request Overview
This PR implements a feature flag to optionally include a CheckRunID in a job context and adds associated L0 tests for the new behavior. Key changes include:
- Adding new L0 tests in JobContextL0.cs to validate setting, unsetting, and retrieving CheckRunID.
- Updating JobContext.cs to expose a nullable CheckRunID property with corresponding dictionary get/set behavior.
- Modifying ExecutionContext.cs to conditionally hydrate the job context based on the feature flag.
- Adding the new feature flag constant in Constants.cs.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Test/L0/Worker/JobContextL0.cs | Added tests for CheckRunID property behavior. |
| src/Test/L0/Worker/ExecutionContextL0.cs | Added tests to verify job context hydration based on flag. |
| src/Runner.Worker/JobContext.cs | Introduced CheckRunID property on JobContext. |
| src/Runner.Worker/ExecutionContext.cs | Updated job context initialization to support the feature. |
| src/Runner.Common/Constants.cs | Added constant for the feature flag. |
ericsciple
reviewed
Apr 28, 2025
ericsciple
previously approved these changes
Apr 29, 2025
ericsciple
approved these changes
May 6, 2025
marko-k0
pushed a commit
to dfinity/runner
that referenced
this pull request
May 13, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
|
How can this kind of information be used? It's already been 3 months since the merge, and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the feature flag is enabled upstream, the job context will now contain a value for
check_run_id, which workflow authors can use in job contexts like${{ job.check_run_id }}.