Allow runner to use authv2 during config. #3866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables the runner to use the Auth V2 endpoint during configuration when specific agent properties are set.
- Adds a conditional block to inject
enableAuthMigrationByDefaultandauthorizationUrlV2into the OAuth credential payload. - Guards the new behavior on the
EnableAuthMigrationByDefaultandAuthorizationUrlV2properties.
Comments suppressed due to low confidence (1)
src/Runner.Listener/Configuration/ConfigurationManager.cs:390
- New functionality for Auth V2 migration is introduced but lacks unit tests. Please add tests under
Test/L0/Runner.Listenerto cover the scenario whenEnableAuthMigrationByDefaultis true andAuthorizationUrlV2is set.
if (agent.Properties.GetValue("EnableAuthMigrationByDefault", false) &&
ericsciple
approved these changes
May 21, 2025
This was referenced Jun 3, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/github/actions-runner-admin/issues/1506