Support refresh runner configs with pipelines service. #3706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
commented
Feb 10, 2025
TingluoHuang
commented
Feb 10, 2025
TingluoHuang
commented
Feb 10, 2025
TingluoHuang
commented
Feb 10, 2025
TingluoHuang
commented
Feb 10, 2025
TingluoHuang
commented
Feb 10, 2025
TingluoHuang
commented
Feb 10, 2025
TingluoHuang
commented
Feb 10, 2025
7cac6dc to
5af59de
Compare
c0faabe to
88e9d8e
Compare
88e9d8e to
e7426f4
Compare
ericsciple
reviewed
Mar 19, 2025
| @@ -130,13 +133,15 @@ public sealed class ConfigurationStore : RunnerService, IConfigurationStore | |||
| { | |||
| private string _binPath; | |||
| private string _configFilePath; | |||
| private string _migratedconfigFilePath; | |||
There was a problem hiding this comment.
migratedConfigFilePath
ericsciple
reviewed
Mar 19, 2025
| await ReportTelemetryAsync("Runner settings updated successfully."); | ||
| } | ||
|
|
||
| private async Task UpdateRunnerCredentialsAsync(string serviceType, string configRefreshUrl, CancellationToken token) |
There was a problem hiding this comment.
Note, this doesn't include the private key. This is just the URL/etc, not the private key - i.e. .credentials not .credentials_rsaparams
ericsciple
previously approved these changes
Mar 19, 2025
ericsciple
approved these changes
Mar 19, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runner would need to exchange its
.runnerand.credentialswith service to finish migration to new backend.We will based on message from service to make request to either pipelines or admin to get a new config file.
The new config will get stored in either
.runner_migratedor.credentials_migrated, which are side by side with existing.runnerand.credentials.We will report telemetry back to service on any failure.
https://github.com/github/actions-runtime/issues/4944