Support auth migration using authUrlV2 in Runner/MessageListener. #3787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b61db0c to
e21c2ee
Compare
ericsciple
reviewed
Apr 3, 2025
| @@ -88,7 +90,8 @@ public async Task<CreateSessionResult> CreateSessionAsync(CancellationToken toke | |||
| try | |||
| { | |||
| Trace.Info("Connecting to the Broker Server..."); | |||
| await _brokerServer.ConnectAsync(new Uri(serverUrlV2), _creds); | |||
| _credsV2 = _credMgr.LoadCredentials(allowAuthUrlV2: true); | |||
There was a problem hiding this comment.
Is this bool used?
It looks like it's passed to GetVssCredentials but unused within that method
There was a problem hiding this comment.
it's only used in OAuthCredential
https://github.com/actions/runner/blob/c1095ae2d100886a7865f466357f09ef30dec1b9/src/Runner.Listener/Configuration/OAuthCredential.cs
e21c2ee to
ec9e8d8
Compare
ericsciple
approved these changes
Apr 10, 2025
marko-k0
pushed a commit
to dfinity/runner
that referenced
this pull request
May 13, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
var cred=LoadCredentials(false)for any connection toRunnerServerandActionsRunServer.We use
var cred=LoadCredentials(true)for any connection toBrokerServerandRunServer.In case any request to
BrokerServerandRunServerhit exception, invokeHostContext.DeferAuthMigration()as needed.https://github.com/github/actions-runner-admin/issues/1656