Enable hostcontext to track auth migration. #3776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4fa2af to
5405d47
Compare
TingluoHuang
commented
Mar 31, 2025
| refreshIntervalInMS = int.Parse(Environment.GetEnvironmentVariable("_GITHUB_ACTION_AUTH_MIGRATION_REFRESH_INTERVAL")); | ||
| } | ||
| #endif | ||
| _authMigrationAutoReenableTask = AuthMigrationAuthReenableAsync(TimeSpan.FromMilliseconds(refreshIntervalInMS), _authMigrationAutoReenableTaskCancellationTokenSource.Token); |
There was a problem hiding this comment.
we only run the background task when someone calls EnableAuthMigration(), so we can make sure we don't run this extra code in GHES for now.
yaananth
approved these changes
Mar 31, 2025
marko-k0
pushed a commit
to dfinity/runner
that referenced
this pull request
May 13, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support runner auth migration from pipelines/token to runner-admin, we need a central place to track the state of migration in the runner.
HostContextis a singleton per runner process, so it's the prefect place to track the state of auth migration.AllowAuthMigration// Boolean for checking if auth migration is allowed.EnableAuthMigration()// Enable auth migrationDeferAuthMigration(TimeSpan)// Temporary disable auth migration for a period of time.event AuthMigrationChanged// Event to notify the change of auth migration statehttps://github.com/github/actions-runner-admin/issues/1656