Small runner code cleanup. #3773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
commented
Mar 28, 2025
| @@ -63,8 +65,7 @@ public async Task<CreateSessionResult> CreateSessionAsync(CancellationToken toke | |||
|
|
|||
| // Create connection. | |||
| Trace.Info("Loading Credentials"); | |||
| var credMgr = HostContext.GetService<ICredentialManager>(); | |||
There was a problem hiding this comment.
move this to class level, since we will going to reuse it later.
TingluoHuang
commented
Mar 28, 2025
| @@ -329,7 +330,7 @@ public async Task<TaskAgentMessage> GetNextMessageAsync(CancellationToken token) | |||
| } | |||
| } | |||
|
|
|||
| public async Task RefreshListenerTokenAsync(CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
removed the CancellationToken cancellationToken from the interface method since no one is using it.
TingluoHuang
commented
Mar 28, 2025
| var configManager = HostContext.GetService<IConfigurationManager>(); | ||
| _settings = configManager.LoadSettings(); | ||
|
|
||
| if (string.IsNullOrEmpty(_settings.ServerUrlV2)) |
There was a problem hiding this comment.
we don't need to check this again, we are in BrokerMessageListener only if we have the ServerUrlV2 in the first place.
ericsciple
approved these changes
Mar 28, 2025
marko-k0
pushed a commit
to dfinity/runner
that referenced
this pull request
May 13, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In prepare for my up coming change, I am making small changes to reduce future PR's diff.