Improve the out-of-date warning message. #3595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
approved these changes
Mar 14, 2025
In case of self-hosted runner, the organization uses the GitHub runner, but they also have their own self-hosted runner "version", with specific configuration being improved over time and through this increasing their own internal "runner version". The way the message was written, sometimes results in confusion, where developer and a devops person start mistakenly assuming that the version is related to their own runner version, and not the actual GitHub runner that runs on that hardware. Time is then lost, until someone realizes that this has nothing to do with the internal "runner version" itself, but with the actual GitHub runner that needs to be upgraded. Message was fixed to explicitely differentiate between "GitHub runner" and the self-hosted runner itself to avoid possible confusion and possibly save someone few minutes of time.
20b2144 to
ed047eb
Compare
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
sirredbeard
pushed a commit
to sirredbeard/runner
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of self-hosted runner, the organization uses the
GitHub runner, but they also have their own self-hosted runner
"version", with specific configuration being improved over time
and through this increasing their own internal "runner version".
The way the message was written, sometimes results in
confusion, where developer and a devops person start mistakenly
assuming that the version is related to their own runner version,
and not the actual GitHub runner that runs on that hardware.
Time is then lost, until someone realizes that this has nothing
to do with the internal "runner version" itself, but with the
actual GitHub runner that needs to be upgraded.
Message was fixed to explicitely differentiate between
"GitHub runner" and the self-hosted runner itself to avoid
possible confusion and possibly save someone few minutes of time.