Properly guard upload #2439
Merged
Properly guard upload #2439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actions#2437)" This reverts commit 8c096ba.
TingluoHuang
previously approved these changes
Feb 17, 2023
| if (timelineRecordId == _jobTimelineRecordId && String.Equals(type, CoreAttachmentType.ResultsLog, StringComparison.Ordinal)) | ||
| { | ||
| Trace.Verbose("Skipping job log {0} for record {1}", path, timelineRecordId); | ||
| return; |
There was a problem hiding this comment.
same here, do we need to delete the file?
There was a problem hiding this comment.
Not going to delete here since I am going to remove this check now in my next PR. I already have the code mostly ready, just need to test and submit a PR.
The general ff case is handled by the first delete above.
TingluoHuang
approved these changes
Feb 17, 2023
nikola-jokic
pushed a commit
to nikola-jokic/runner
that referenced
this pull request
May 12, 2023
* Revert "Revert "Uploading step logs to Results as well (actions#2422)" (actions#2437)" This reverts commit 8c096ba. * Properly guard the upload to results feature * Delete skipped file if deletesource is true
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jun 17, 2024
* Revert "Revert "Uploading step logs to Results as well (actions#2422)" (actions#2437)" This reverts commit 8c096ba. * Properly guard the upload to results feature * Delete skipped file if deletesource is true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 2.302 upload log issue