Skip to content

Use cache in check-dist.yml #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2022
Merged

Use cache in check-dist.yml #876

merged 1 commit into from
Dec 8, 2022

Conversation

jongwooo
Copy link
Contributor

@jongwooo jongwooo commented Dec 6, 2022

Signed-off-by: jongwooo jongwooo.han@gmail.com

Description

Use cache in check-dist.yml
See actions/cache#1004

AS-IS

- name: Set Node.js 16.x
  uses: actions/setup-node@v3
  with:
    node-version: 16.x

TO-BE

- name: Set Node.js 16.x
  uses: actions/setup-node@v3
  with:
    node-version: 16.x
    cache: npm

It’s literally a one line change to pass the cache: npm input parameter.

@jongwooo
Use cache in check-dist.yml
f6a9b6a 
Signed-off-by: jongwooo <jongwooo.han@gmail.com>
@jongwooo jongwooo requested a review from a team as a code owner December 6, 2022 16:01
@steveluscher
Copy link

Nice one! Let's get this in.

@IvanZosimov IvanZosimov merged commit 975308f into actions:main Dec 8, 2022
@jongwooo jongwooo deleted the chore/use-cache-in-check-dist branch December 8, 2022 13:37
@irega irega mentioned this pull request Dec 13, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marko-zivic-93 marko-zivic-93 Awaiting requested review from marko-zivic-93

3 more reviewers

@dmitry-shibanov dmitry-shibanov dmitry-shibanov approved these changes

@MaksimZhukov MaksimZhukov MaksimZhukov approved these changes

@IvanZosimov IvanZosimov IvanZosimov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jongwooo @steveluscher @dmitry-shibanov @MaksimZhukov @IvanZosimov @marko-zivic-93