Fix workflow example for downloading by artifact ID #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the workflow example to support downloading artifacts by defining and exposing the artifact ID as an output.
- Added a job-level output for the artifact ID in the upload job
- Renamed the upload step to "upload-step" and updated its reference in the subsequent step
- Improved readability with spacing and comments
Comments suppressed due to low confidence (1)
docs/MIGRATION.md:231
- The step id 'upload-step' is clear in this context; ensure that all related references remain consistent as per the updated output mapping.
id: upload-step
joshmgross
commented
Apr 23, 2025
Comment on lines
-13
to
-17
| paths-ignore: | ||
| - '**.md' | ||
| pull_request: | ||
| paths-ignore: | ||
| - '**.md' |
There was a problem hiding this comment.
Since this is required CI, we can't skip it.
GrantBirki
approved these changes
Apr 23, 2025
robherley
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
artifact-idsinput #401@ramonpetgrave64 pointed out that the upload job was not defining any outputs, preventing this example from working:
#401 (comment)
I've updated the example to define that job output and make it clear that the upload step output is not being passed directly between jobs. I've also added some spacing for readability.