Skip to content

Conversation

bdehamer
Copy link
Collaborator

This change is primarily about updating eslint from 8.x to 9.x but also includes a number of related changes to the linter configuration.

  • Switch to the new eslint flat config format.
  • Remove integration between eslint and prettier (per guidance from the Prettier team).
  • Remove the @typescript-eslint/eslint-plugin and @typescript-eslint/parser plugins in favor of the new typescript-eslint package.
  • Remove the unused eslint-plugin-jsonc package.
  • Remove the eslint-plugin-github package. This package contains a lot of duplicate rules and prettier-related integration that we no longer want/need.

By removing the eslint-plugin-github package, the only rules we losing are those from the eslint-plugin-eslint-comments package (which is of minimal value) and the following GitHub-specific rules:

@bdehamer bdehamer requested a review from a team as a code owner December 13, 2024 21:12
Signed-off-by: Brian DeHamer <bdehamer@github.com>
@bdehamer bdehamer force-pushed the bdehamer/eslint-update branch from fe4c055 to 0ba29f6 Compare December 16, 2024 15:15
Copy link
Contributor

@ejahnGithub ejahnGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bdehamer bdehamer merged commit ae2702e into main Dec 16, 2024
21 checks passed
@bdehamer bdehamer deleted the bdehamer/eslint-update branch December 16, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants