Improved checksum parsing #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the tolerance of checksum file parsing by making the input mode flag character optional, addressing compatibility issues with tools that don't include the binary/text mode indicator.
Key changes:
- Updated parsing logic to handle checksums with or without the mode flag character ('*' or ' ')
- Added comprehensive test coverage for the new parsing behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/subject.ts | Modified checksum parsing to optionally handle mode flag characters |
| tests/subject.test.ts | Added test cases for checksums with and without mode flags |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Brian DeHamer <bdehamer@github.com>
0dd0eec to
55baa83
Compare
ejahnGithub
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per: actions/attest-build-provenance#454 (comment)
Improve parsing of checksums files to make more tolerant of different formats.
Most tools which generate checksums follow the guidance for the GNU md5sum tool:
However, not all tools include the input mode flag. This change will updating the parsing logic to make it tolerant of tools which don't include the input mode flag.