Skip to content

Conversation

kotewar
Copy link
Contributor

@kotewar kotewar commented May 30, 2022

As part of fix needed for #624 , actions/toolkit was modified recently to warn the user telling no cache is being saved when there are no paths matching the given input paths.

This PR is to update the @actions/cache dependency with recently published v2.0.5 version of the same.

@kotewar kotewar requested a review from a team as a code owner May 30, 2022 06:07
@github-actions github-actions bot requested a review from tiwarishub May 30, 2022 06:08
Copy link
Contributor

@tiwarishub tiwarishub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

### 3.0.2
- Added support for dynamic cache size cap on GHES.

### 3.0.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we doing 2 releases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're doing only one release i.e. 3.0.3. We had missed updating release notes for the previous release, hence added that information here just to track the same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice. you might also want to add these to README.md. I'll suggest removing v2 from there now as they are quite old.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let me do that as well. Will also update the link for

Refer here for previous versions

to v2 as it is currently pointing to v1 README.

@kotewar
Copy link
Contributor Author

kotewar commented May 31, 2022

Tested the changes in my local repository. Things are working as expected. Merging the PR.

@kotewar kotewar merged commit 30f413b into main May 31, 2022
@kotewar kotewar deleted the users/kotewar/update-actions-cache-version branch May 31, 2022 07:03
@kotewar kotewar linked an issue May 31, 2022 that may be closed by this pull request
@lsdm83114
Copy link

lsdm83114 commented May 26, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not save cache if files are empty
4 participants