Skip to content

Cache-Hit set to string, not boolean, as of v4.1.0 #1466

@bigdogwillfeed

Description

@bigdogwillfeed

After a recent upgrade, our runners started behaving differently on cache miss.

As of 0c45773, a step defined with if: steps.cache-release.outputs.cache-hit would be skipped if the "cache release" job missed the cache, as intended. As of 2cdf405, the job now runs on cache miss, despite clearly missing the cache.

Here's a relevant snippet of the run with debug logging enabled

Cache not found for input keys: release-0e0ceb0ce2360a93ec77b898ac06177b7429666b
##[debug]Node Action run completed with exit code 0
##[debug]Save intra-action state CACHE_KEY = release-0e0ceb0ce2360a93ec77b898ac06177b7429666b
##[debug]Set output cache-hit = false
##[debug]Finishing: Cache release folder
<snip>
##[debug]Evaluating condition for step: 'Panic if build already exists'
##[debug]Evaluating: (success() && steps.cache-release.outputs.cache-hit)
##[debug]Evaluating And:
##[debug]..Evaluating success:
##[debug]..=> true
##[debug]..Evaluating Index:
##[debug]....Evaluating Index:
##[debug]......Evaluating Index:
##[debug]........Evaluating steps:
##[debug]........=> Object
##[debug]........Evaluating String:
##[debug]........=> 'cache-release'
##[debug]......=> Object
##[debug]......Evaluating String:
##[debug]......=> 'outputs'
##[debug]....=> Object
##[debug]....Evaluating String:
##[debug]....=> 'cache-hit'
##[debug]..=> 'false'
##[debug]=> 'false'
##[debug]Expanded: (true && 'false')
##[debug]Result: 'false'
##[debug]Starting: Panic if build already exists

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions