Skip to content

Use @actions/github for rest calls instead of axios #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 16, 2023
Merged

Use @actions/github for rest calls instead of axios #63

merged 12 commits into from
Feb 16, 2023

Conversation

jeremy-daley-kr
Copy link
Contributor

Seems better to use Github's JS packages to do REST calls rather than manually constructing axios requests. Plus it fixes potential proxy issues (currently happening with use of axios) for organizations using self-hosted runners.

@jeremy-daley-kr jeremy-daley-kr requested a review from a team as a code owner February 10, 2023 08:18
@jeremy-daley-kr jeremy-daley-kr mentioned this pull request Feb 10, 2023
Closed
@daleyjem
Copy link

@JamesMGreene You seem to have the most contrib in this repo and the deploy-pages one, where I have proxy-related PRs for both. Any chance you can give these a look?

This is the deploy-pages one: actions/deploy-pages#111

@JamesMGreene
Copy link
Contributor

@daleyjem The idea seems sound, though it looks like a few more changes might be necessary. I'll try to get this merged today or tomorrow! 👀

@JamesMGreene JamesMGreene mentioned this pull request Feb 13, 2023
Closed
@daleyjem
Copy link

@daleyjem The idea seems sound, though it looks like a few more changes might be necessary. I'll try to get this merged today or tomorrow! 👀

Thanks @JamesMGreene. Just pushed up the prettier fix.

@JamesMGreene JamesMGreene merged commit 8ece2a9 into actions:main Feb 16, 2023
@JamesMGreene
Copy link
Contributor

@jeremy-daley-kr After some tweaks on our side, I've merged this and released it as v3.0.4 / the latest v3. When you get a chance, please confirm that it met your needs for honoring proxies! 🙇🏻

Thanks again for the PR! 💝

@daleyjem
Copy link

daleyjem commented Feb 16, 2023 •
edited
Loading

@JamesMGreene Appears to have worked! Thanks! FWIW... I added another comment on the deploy-pages PR.

Also, sorry about the confusion of different Github users... I started this stuff on my work machine 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremy-daley-kr @daleyjem @JamesMGreene