Skip to content

Update tests to actually invoke the desired method instead of replicating it #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2023
Merged

Update tests to actually invoke the desired method instead of replicating it #53

merged 2 commits into from
Feb 1, 2023

Conversation

JamesMGreene
Copy link
Contributor

I noticed our tests for setPagesConfig weren't actually invoking setPagesConfig but rather replicating the contents of that method. Doesn't seem like we needed to do that, so I've closed that potential gap. 🤷🏻‍♂️

@JamesMGreene JamesMGreene requested a review from a team as a code owner January 31, 2023 14:14
@JamesMGreene JamesMGreene merged commit 1d79de2 into main Feb 1, 2023
@JamesMGreene JamesMGreene deleted the test-set-pages-config branch February 1, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@felipesu19 felipesu19 felipesu19 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesMGreene @felipesu19