Skip to content

Fix enablement logic in v3 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2023
Merged

Fix enablement logic in v3 #50

merged 2 commits into from
Jan 30, 2023

Conversation

JamesMGreene
Copy link
Contributor

My bad. 😓

When I made the small change to switch the enablement logic to default to false for v3.x (see #48), I messed it up. 🤦🏻‍♂️

Thanks to @acdoussan for pointing out the misbehavior in #40 (comment)

@JamesMGreene JamesMGreene requested a review from a team as a code owner January 30, 2023 18:32
@JamesMGreene JamesMGreene merged commit 3c444c0 into main Jan 30, 2023
@JamesMGreene JamesMGreene deleted the fix-enablement branch January 30, 2023 18:34
@JamesMGreene JamesMGreene mentioned this pull request Jan 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@YiMysty YiMysty YiMysty approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesMGreene @YiMysty