By the way, I believe sass-rails wants to support sassc, but they haven't updated their progress on that since 2017:

rails/sass-rails#349 (comment)

Thanks for that info @DeeDeeG! In that case, I guess it's better to leave things as they are now, leaving it opened for the application to choose just in case. 👍

No problem, and thank you for responding to this situation so quickly!

Codecov Report

Merging #5504 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5504      +/-   ##
==========================================
- Coverage   98.38%   98.38%   -0.01%     
==========================================
  Files         293      293              
  Lines       11078    11073       -5     
==========================================
- Hits        10899    10894       -5     
  Misses        179      179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 334c85d...2c25ff5. Read the comment docs.

sassc-rails is in the process of adding jruby support, and this is green when tested against the PR adding support 👍.

Thoughts on depending on sassc-rails vs depending on sassc?

Awesome! I checked the PR there as well. That's great news! In regard to which dependency, I'm not really sure. I have followed what other libraries do. I think if we have been fine with just including sass (excluding the EOL part) then perhaps good to just stick with sassc for now. What do you think is best?

I don't have a strong opinion, what you said makes sense, so I'll leave it as it is for now.

Sounds good then, we’ll stick with this for now thanks! Should we wait for a sassc-rails before we merge this?

Yeah, I think there's no rush 👍

Some updates here. sassc-rails released a new version that dropped the sass dependency, but now we're waiting on a new release that fixes jruby support.

Also, I noticed #5226, due to the fact of depending on plain sass instead of sass-rails. So I'm tempted introduce sassc-rails as a runtime dependency as I suggested in the first message.

Some extra updates. Everything this was blocked in has been released, so this should be ready to go. I've also added sassc-rails as a runtime dependency and I'm waiting for confirmation that doing this fixes #5226.

I'm holding this off a bit longer, because it's unclear to me whether the sassc-rails will be needed or not in the future.

I fixed sassc support in sprockets recently and now our specs pass against sprockets master without the sassc-rails dependency. This is because the main stuff provided by sassc-rails, a sprockets compresor and a sprockets processor are also builtin in sprockets.

So I think sassc-rails might end up being completely merged into sprockets. I propose to wait and see how rails handles this, and do the same.

[Edit: Whoops, looks like this is just narrowly off-topic. Sorry about that, and feel free to ignore this comment.]

Hi again!

There is a PR to make sass-rails a lightweight wrapper for sassc-rails.

• Ruby Sass End-of-Life: 26 March 2019 rails/rails#32896 (comment)

  • We decided to make sass-rails a thin wrapper for sassc-rails, see Make sass-rails an wrapper for sassc-rails to allow a smooth upgrade rails/sass-rails#424

This is only as of a day ago, so I guess it might not happen exactly that way without some further comments/consensus or something, but you know. Looks like that's the plan so far.

[Edit 2: The PR I mentioned here is now merged. Should become part of sass-rails 6.0, whenever that comes out.]

good work 🎉 👍

Thanks!! Let's do this!

Woohoo 🎉

Awesome thanks! Curious why didn’t we use sass-rails instead? From what I understood that would continue to get updated to avoid issues or perhaps the plan for that gem is to slowly get users to switch to sassc-rails instead?

Yeah, I had the same doubt. I asked in the rails repo in a couple of related issues, but nobody answered.

The way I see it, sass-rails is getting abandoned. It's currently just a wrapper around sassc-rails.