Only depend on profiling-procmacros if the procmacros feature was set
#61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 19, 2023
|
My primary concern is that we do not cause any problems for the wgpu crate and their MSRV is 1.65, so I think in this case the benefit outweighs the risk. We can always yank if this bump ends up causing breakage for other people. BTW thanks for all the work you've done with egui and epaint. Been using it a lot lately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
profiling = { version = "1.0.12", optional = true, default-features = false, features = ["profile-with-puffin"] }would still addprofiling-procmacrosas a dependency.To support this, MSRV must be increased to 1.60 (released 2022-04-07)