Skip to content
This repository was archived by the owner on Mar 16, 2024. It is now read-only.

Conversation

iwilltry42
Copy link
Contributor

@iwilltry42 iwilltry42 commented Jan 22, 2024

Missed a few spots to unescape dots in env var keys again after they've been escaped during unmarshalling.

Previous PR: #2428

Ref #2442

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Signed-off-by: Thorsten Klein <tk@thklein.io>
@iwilltry42 iwilltry42 changed the title fix: unescape dots in env names fix: unescape dots in env names (#2442) Jan 22, 2024
@iwilltry42 iwilltry42 merged commit 10a81f7 into acorn-io:main Jan 23, 2024
@iwilltry42 iwilltry42 deleted the change/escape-dots-in-env branch January 23, 2024 09:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants