This repository was archived by the owner on Mar 16, 2024. It is now read-only.
fix: remove potential to panic when validating computeclass create requests #2403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quests Signed-off-by: tylerslaton <mtslaton1@gmail.com>
tylerslaton
commented
Jan 10, 2024
Comment on lines
+146
to
+148
| if resources == nil { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
This is the critical logic
cjellick
approved these changes
Jan 10, 2024
keyallis
approved these changes
Jan 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR we had the potential to panic when validating the creation of the public compute class types. This PR addresses that issue and refactors for readbility.
For #2401
Checklist
This is a title (#1216). Here's an example