Skip to content
This repository was archived by the owner on Mar 16, 2024. It is now read-only.

Conversation

iwilltry42
Copy link
Contributor

@iwilltry42 iwilltry42 commented Nov 15, 2023

This translates to containerSecurityContext.RunAsUser|RunAsGroup

Ref #718

Example:

containers: foo: {
  image: "some/image:v1"
  user: "1000:1000"
}

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

This translates to containerSecurityContext.RunAsUser|RunAsGroup

Signed-off-by: Thorsten Klein <tk@thklein.io>
Signed-off-by: Thorsten Klein <tk@thklein.io>
Copy link
Contributor

@keyallis keyallis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of testing case suggestions but otherwise looks good to me

Signed-off-by: Thorsten Klein <tk@thklein.io>
Signed-off-by: Thorsten Klein <tk@thklein.io>
@iwilltry42 iwilltry42 merged commit a822ff9 into acorn-io:main Nov 21, 2023
@iwilltry42 iwilltry42 deleted the iwilltry42/issue718 branch November 21, 2023 05:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants