Skip to content
This repository was archived by the owner on Nov 19, 2020. It is now read-only.

Conversation

CatchemAL
Copy link
Collaborator

@CatchemAL CatchemAL commented Sep 21, 2017

As discussed in #882:

The LuDecomposition and CholeskyDecomposition classes expose properties with a simple Lazy evaluation pattern on the factored matrices. The QrDecomposition does not do this. Any unsuspecting user attempting to iterate through, say, the UpperTriangleFactor directly is in for a nasty shock as the matrix could potentially be rebuilt thousands of times.

Propose lazy cache on QR properties (or method call if caching undesirable). On phone but can post code snippet later if this is not clear. SVD has a few issues as well.

Fixed a few others and added checks in the unit test, Assert.AreSame() to check instance equality.

Thanks,
Alex

This closes #882

@cesarsouza cesarsouza merged commit 22ae097 into accord-net:development Sep 21, 2017
@cesarsouza
Copy link
Member

Thanks, excellent as usual!

@CatchemAL CatchemAL deleted the GH-882 branch September 22, 2017 03:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QR Decomposition not caching work intensive properties
2 participants