-
Notifications
You must be signed in to change notification settings - Fork 46
company-ycmd: Use new format for python functions in ycmd #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
company-ycmd: Use new format for python functions in ycmd #431
Conversation
ycmd now indicates a python function in extra_menu_info with `def` instead of `function`. See: ycm-core/ycmd@72bfc38
d9e75f5
to
992b646
Compare
I tested the code and it didn't fix the issue. Still see the function definition being suggested as Moreover I guess this change would break backward compatibility as is. |
Looking a bit further from the logic you pointed out. Trying the following code:
It seems that the function Looking closer, it seems it cannot get the function signature from the I just tested with Python standard library and the parameters are indeed showing. So it's probably something wrong with my env vars. Yet it is weird as the semantic completion seems to work, all functions and classes defined in the |
@noxdafox I tried you code snippet and I have the same behavior. If you run The problem before was the parsing of the params itself which the #431 fixes Maybe worth asking in the |
Yes I will open an issue against their project. For this patch, IMHO would be better to ensure backward compatibility. |
|
Ycmd is enforcing specific version of its dependency right now that it's under heavy development, hopefully in future it will change. Bear in mind the User might still be using old Ycmd. Debian, for example, now ships a ycmd package: https://packages.debian.org/sid/ycmd The change would break compatibility with that version for example. |
Not sure why you are saying that. It points to the Jedi release 0.10.2 which is supposed to be stable. |
What I mean is that I hope to be able to use distribution packages rather than pulling the source code of all the dependencies in future. |
@ptrv I tried an older version of ycmd and I get the paramters completion as well (see ycm-core/ycmd#773). EDIT: I forgot to eval the change. Reverting this commit makes company-ycmd showing the function parameters again. So it's definitely something wrong in recent |
Issue abingham/emacs-ycmd#431 was fixed. Signed-off-by: Matteo Cafasso <noxdafox@gmail.com>
ycmd now indicates a python function in extra_menu_info with
def
instead offunction
.See:
ycm-core/ycmd@72bfc38