Skip to content

Migrate to Ruff #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 15, 2023
Merged

Migrate to Ruff #646

merged 3 commits into from
Jul 15, 2023

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Jul 15, 2023 •
edited
Loading

Description

Use Ruff, deprecate sort.

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

abey79 added 2 commits July 15, 2023 14:46
@abey79
Migrated to Ruff
7765eb1 
- updated deps
- enabled a bunch of ruff rules
- fixed all ruff errors
@abey79
- Removed isort from dev deps
0ec587d 
- Updated PR template
- CHANGELOG.md
@codecov
Copy link

codecov bot commented Jul 15, 2023 •
edited
Loading

Codecov Report

Patch coverage: 96.29% and no project coverage change.

Comparison is base (dcd52bd) 94.77% compared to head (91c982a) 94.77%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #646   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files          62       62           
  Lines        5721     5724    +3     
  Branches     1304     1304           
=======================================
+ Hits         5422     5425    +3     
  Misses        182      182           
  Partials      117      117
Impacted Files Coverage Δ
tests/test_commands.py 99.08% <ø> (ø)
tests/test_hpgl.py 100.00% <ø> (ø)
vpype/config.py 97.91% <ø> (ø)
vpype/metadata.py 100.00% <ø> (ø)
vpype/text.py 92.56% <ø> (ø)
vpype/utils.py 96.61% <ø> (ø)
vpype_cli/blocks.py 97.70% <ø> (ø)
vpype_cli/decorators.py 95.40% <ø> (ø)
vpype_cli/eval.py 100.00% <ø> (ø)
vpype_cli/frames.py 100.00% <ø> (ø)
... and 27 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abey79 abey79 merged commit dc8916d into master Jul 15, 2023
@abey79 abey79 deleted the ruff branch July 15, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abey79