Fixed how write handles opacity in SVG output
#429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inkscape does not support alpha in `stroke` attribute (e.g. `stroke="#ff00007f"`). The attribute `stroke-opacity` must be used instead.
updated CHANGELOG.md
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
==========================================
+ Coverage 93.83% 93.87% +0.03%
==========================================
Files 59 59
Lines 5210 5222 +12
Branches 766 766
==========================================
+ Hits 4889 4902 +13
+ Misses 205 204 -1
Partials 116 116
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inkscape does not support alpha in
strokeattribute (e.g.stroke="#ff00007f"). The attributestroke-opacitymust be used instead.Fixes #422
Checklist
blackandisort)mypyreturns no errorpytestsucceedshelpreference.rstmake clean && make htmlindocs/)