Skip to content

Fixed vp_source[s] to use absolute paths #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Feb 25, 2022

Description

Fixed vp_source[s] to use absolute paths

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

@abey79 abey79 force-pushed the fix-source-not-absolute branch from 3f8cd31 to ef60822 Compare February 25, 2022 10:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #408 (ef60822) into master (bdd8c86) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #408   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files          59       59           
  Lines        5160     5160           
  Branches      719      719           
=======================================
  Hits         4838     4838           
  Misses        207      207           
  Partials      115      115           
Impacted Files Coverage Δ
vpype/io.py 84.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd8c86...ef60822. Read the comment docs.

@abey79 abey79 merged commit 7efbfdf into master Feb 28, 2022
@abey79 abey79 deleted the fix-source-not-absolute branch February 28, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant