Skip to content

Conversation

jimmykl
Copy link
Contributor

@jimmykl jimmykl commented May 1, 2022

Description

to be completed

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

@jimmykl
Copy link
Contributor Author

jimmykl commented May 1, 2022

Config created with a lot of help from @ithinkido

@abey79
Copy link
Owner

abey79 commented May 2, 2022

Thanks for the contribution!

Please add the following line in CHANGELOG.md (under 'New feature') and I'll merge:

* Added HPGL configuration for the Houston Instrument DMP-161 plotter (thanks to @jimmykl and @ithinkido) (#472)

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #472 (dde5b4e) into master (ab39d5b) will not change coverage.
The diff coverage is n/a.

❗ Current head dde5b4e differs from pull request most recent head 28127a7. Consider uploading reports for the commit 28127a7 to get more accurate results

@@           Coverage Diff           @@
##           master     #472   +/-   ##
=======================================
  Coverage   94.38%   94.38%           
=======================================
  Files          60       60           
  Lines        5396     5396           
  Branches      786      786           
=======================================
  Hits         5093     5093           
  Misses        185      185           
  Partials      118      118           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab39d5b...28127a7. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jimmykl
Copy link
Contributor Author

jimmykl commented May 7, 2022

Thanks for the contribution!

Please add the following line in CHANGELOG.md (under 'New feature') and I'll merge:

* Added HPGL configuration for the Houston Instrument DMP-161 plotter (thanks to @jimmykl and @ithinkido) (#472)

Done, thanks @abey79

@abey79 abey79 merged commit faad5b2 into abey79:master May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants