Skip to content

HPGL export improvements #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 17, 2021
Merged

HPGL export improvements #316

merged 4 commits into from
Oct 17, 2021

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Oct 13, 2021 •
edited
Loading

Description

This PR improves HPGL export in a couple of ways:

Checklist

  • fix tests for HPGL
  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy vpype vpype_cli tests returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • RTD doc updated and building with no error (make clean && make html in docs/)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #316 (5ce2ac1) into master (2de339b) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
- Coverage   92.14%   92.06%   -0.08%     
==========================================
  Files          50       50              
  Lines        3934     3945      +11     
  Branches      515      520       +5     
==========================================
+ Hits         3625     3632       +7     
- Misses        206      209       +3     
- Partials      103      104       +1
Impacted Files Coverage Δ
tests/test_hpgl.py 100.00% <100.00%> (ø)
vpype/io.py 77.62% <100.00%> (+0.78%) ⬆️
vpype_cli/write.py 84.31% <100.00%> (+0.31%) ⬆️
vpype_viewer/_utils.py 100.00% <100.00%> (ø)
vpype/utils.py 82.60% <0.00%> (-2.90%) ⬇️
vpype/layers.py 77.77% <0.00%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2de339b...5ce2ac1. Read the comment docs.

@abey79 abey79 merged commit 000e328 into master Oct 17, 2021
@abey79 abey79 deleted the feature-relative-hpgl branch October 17, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve HPGL pen change logic Use relative coordinates for HPGL output to reduce file size
1 participant
@abey79