Skip to content

Fix property substitution on empty layer #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2022
Merged

Fix property substitution on empty layer #396

merged 1 commit into from
Feb 4, 2022

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Feb 4, 2022 •
edited
Loading

Description

Fix property substitution on empty layer

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abey79 abey79 mentioned this pull request Feb 4, 2022
Merged
10 tasks
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #396 (5a7aca5) into master (6c347bd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #396   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files          56       56           
  Lines        4663     4666    +3     
  Branches      648      648           
=======================================
+ Hits         4362     4365    +3     
  Misses        201      201           
  Partials      100      100
Impacted Files Coverage Δ
tests/test_property_substitution.py 100.00% <100.00%> (ø)
vpype_cli/state.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c347bd...5a7aca5. Read the comment docs.

@abey79 abey79 merged commit 75c9ef9 into master Feb 4, 2022
@abey79 abey79 deleted the fix-subst-empty-layer branch February 4, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abey79