Skip to content

Change system property convention to vp_ instead of vp: #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 1, 2022
Merged

Change system property convention to vp_ instead of vp: #389

merged 5 commits into from
Feb 1, 2022

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Feb 1, 2022 •
edited
Loading

Description

This change will make (most) property name compatible with the str.format() mini-language, which will be used throughout vpype_cli in the future.

Also:

  • Improved namespace detection regex
  • Fixed overwriting of inkscape layer name in write_svg()

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

abey79 added 2 commits February 1, 2022 12:31
@abey79
Change system property convention to vp_ instead of vp:
8a7003a 
- Improved namespace detection regex
- Fixed overwriting of inkscape layer name in write_svg()
@abey79
Updated CHANGELOG.md
caccab2
@codecov
Copy link

codecov bot commented Feb 1, 2022 •
edited
Loading

Codecov Report

Merging #389 (a0c3db7) into master (ea2c87d) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   92.71%   92.89%   +0.17%     
==========================================
  Files          55       55              
  Lines        4573     4587      +14     
  Branches      637      639       +2     
==========================================
+ Hits         4240     4261      +21     
+ Misses        222      217       -5     
+ Partials      111      109       -2
Impacted Files Coverage Δ
tests/test_commands.py 98.95% <ø> (ø)
vpype_cli/metadata.py 92.18% <ø> (ø)
vpype_cli/read.py 95.12% <ø> (ø)
tests/test_files.py 98.36% <100.00%> (+0.13%) ⬆️
vpype/io.py 82.27% <100.00%> (+1.97%) ⬆️
vpype/metadata.py 100.00% <100.00%> (ø)
vpype_viewer/engine.py 96.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea2c87d...a0c3db7. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abey79 abey79 merged commit 63a44cc into master Feb 1, 2022
@abey79 abey79 deleted the sysprop_rename branch February 1, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abey79