Skip to content

Add --keep option to the ldelete command (to delete all layers but those specified) #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Jan 20, 2022

Description

Useful e.g when loading a single layer from a SVG file:

vpype read input.svg ldelete --keep 2

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

@abey79 abey79 force-pushed the ldelete-keep-option branch from 3db0df4 to a1da66a Compare January 20, 2022 12:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #383 (a1da66a) into master (c3aa631) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   92.72%   92.73%   +0.01%     
==========================================
  Files          53       53              
  Lines        4535     4542       +7     
  Branches      636      637       +1     
==========================================
+ Hits         4205     4212       +7     
  Misses        220      220              
  Partials      110      110              
Impacted Files Coverage Δ
tests/test_layers.py 100.00% <100.00%> (ø)
vpype_cli/layerops.py 98.16% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3aa631...a1da66a. Read the comment docs.

@abey79 abey79 merged commit e8aab42 into master Jan 20, 2022
@abey79 abey79 deleted the ldelete-keep-option branch January 20, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant