Added sorting by attribute to read command
#378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added vpype.read_svg_by_attribute() to read SVG sorting geometries by attribute(s) - multiple refactoring in vpype/io.py - added `--attr` option to `read` command to enable sorty by attribute - `read` now use single-layer mode when `--layer` is used, even if `--single-layer` is not used (fixes #36) - updated tests
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
+ Coverage 92.55% 92.72% +0.17%
==========================================
Files 53 53
Lines 4457 4534 +77
Branches 621 636 +15
==========================================
+ Hits 4125 4204 +79
+ Misses 222 220 -2
Partials 110 110
Continue to review full report at Codecov.
|
- added cookbook section - improved coverage of the `read` command - changelog updated
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
readcommand can now sort geometries by layers based on attribute. For example, this sorts geometries by stroke color:Multiple attributes can be provided, in which case one layer will be created for each unique combination of attribute:
Fixes #35
Other changes:
readnow use single-layer mode when--layeris used, even if--single-layeris not used (fixes read: --layer X should imply --single-layer (instead of being ignored) #36)Checklist
blackandisort)mypyreturns no errorpytestsucceedshelpreference.rstmake clean && make htmlindocs/)