Skip to content

Conversation

Ben9ka
Copy link
Contributor

@Ben9ka Ben9ka commented Feb 18, 2025

Objecthandler did not accommodate for icf node created for the http service in older releases

Objecthandler did not accommodate for icf node created for the http service in older releases
@fabianlupa
Copy link
Member

fabianlupa commented Feb 20, 2025

I see you also removed the SUSH object creation but did not comment on that. Any reason?

Edit: I am also asking because I think we do currently have some problems with SUSH as I get many duplicates with different unique IDs after pulling objects and abapGit is unable to delete some SUSH objects.

@Ben9ka
Copy link
Contributor Author

Ben9ka commented Feb 20, 2025

Sorry i forgot to mention it. The sush object is already created by the http service API. It was redundant.

@mbtools mbtools added the serialization Translate between object types and files label Feb 21, 2025
@larshp
Copy link
Member

larshp commented Feb 26, 2025

@fabianlupa any additional thoughts/comments? if not I think its good to merge

@fabianlupa
Copy link
Member

@fabianlupa any additional thoughts/comments? if not I think its good to merge

No. SUSH will be a different issue :)
Looks fine to me, didn't test it though.

Copy link
Member

@larshp larshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@larshp larshp merged commit adc1dad into abapGit:main Feb 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
serialization Translate between object types and files
Development

Successfully merging this pull request may close these issues.

4 participants