Skip to content

Conversation

ThomasPloski
Copy link
Collaborator

fixes issue #7099

ThomasPloski and others added 7 commits December 4, 2024 12:48
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
ThomasPloski and others added 19 commits December 5, 2024 08:24
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@mbtools
Copy link
Member

mbtools commented Dec 5, 2024

Also needs a test, please https://github.com/abapGit-tests/HTTP

PS: This closes #5522. Just made it in under 1000 days 😉

@mbtools mbtools added serialization Translate between object types and files new feature New feature or request ci Findings from CI test runs labels Dec 10, 2024
@ThomasPloski
Copy link
Collaborator Author

Also needs a test, please https://github.com/abapGit-tests/HTTP

PS: This closes #5522. Just made it in under 1000 days 😉

Test data provided

@mbtools
Copy link
Member

mbtools commented Dec 17, 2024

  • Update description
  • Replace LANG data element
  • Consolidate try-catch
  • Changed test case from if_http_service_extension to if_http_extension

It almost works... Error during activation of the HTTP dest:

image

It happens when the system tries to generate the ICF node

image

subrc = 16, Error in Transport Check/Insert for SICF Object

devclass is initial. it's set properly in tadir but not passed to the activation.

mmm, this might take a while to figure out 🤷

@mbtools
Copy link
Member

mbtools commented Dec 17, 2024

It looks like if_http_service_extension is a requirement, but an earlier check fails. maybe it's doesn't work on-prem or on 7.54

@Ben9ka
Copy link
Contributor

Ben9ka commented Dec 19, 2024

if_http_service_extension is the interface for the handler of a http object. What was the reason for changing it to if_http_extension in the test repo?

@mbtools
Copy link
Member

mbtools commented Dec 20, 2024

I reverted the test repo to if_http_service_extension.

It fails in CL_UCON_API_HTTP_SERVICE->if_ucon_api_http_service~set_handler where it's looking for if_http_extension:

image

The result is an "Invalid handler" error:

image

This is on 754 SP 7

@Ben9ka
Copy link
Contributor

Ben9ka commented Dec 20, 2024

Its a bug in CL_UCON_API_HTTP_SERVICE->if_ucon_api_http_service~set_handler in older releases, there will be a correction for it in the future.

@mbtools
Copy link
Member

mbtools commented Dec 20, 2024

Is it just the name of the interface or is it a bigger correction?

@Ben9ka
Copy link
Contributor

Ben9ka commented Dec 20, 2024

It's a bigger correction. Changing the interface would let you activate the service but not release it and the publish locally-Button is missing in the older releases. These releases used a Transaktion like SICF. But the transactions require a Service Node, which the API doesn't create.

@mbtools
Copy link
Member

mbtools commented Dec 20, 2024

ok. Please test that it works fine with the small changes I made above. We can merge it then. I will add it to our CI when it is upgraded to 758 next year.

@mbtools mbtools merged commit 9f00aac into abapGit:main Jan 1, 2025
7 checks passed
@Ben9ka
Copy link
Contributor

Ben9ka commented Feb 17, 2025

The note 3554855 has been released and should fix the issue for older releases.

@Ben9ka
Copy link
Contributor

Ben9ka commented Feb 18, 2025

it required a change in the git handler as well to include the created sicf node, see this pull request .

mbtools added a commit to abapGit/docs.abapgit.org that referenced this pull request Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Findings from CI test runs new feature New feature or request serialization Translate between object types and files
Development

Successfully merging this pull request may close these issues.

4 participants